Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Image.Data API #430

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Remove deprecated Image.Data API #430

merged 2 commits into from
Jul 26, 2022

Conversation

luca-della-vedova
Copy link
Member

@luca-della-vedova luca-della-vedova commented Jun 30, 2022 •
edited
Loading

🦟 Bug fix

Summary

Migrate to new Image API to avoid deprecation warnings, API introduced in this gz-common PR.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@luca-della-vedova
Remove deprecated image.data API
885759b 
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 30, 2022
This was referenced Jun 30, 2022
Closed
Merged
@mjcarroll mjcarroll self-requested a review June 30, 2022 12:09
@mjcarroll mjcarroll added the needs upstream release Blocked by a release of an upstream library label Jun 30, 2022
@chapulina chapulina added the bug Something isn't working label Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022 •
edited
Loading

Codecov Report

Merging #430 (a7004dc) into main (eeb7244) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   66.47%   66.51%   +0.04%     
==========================================
  Files          44       44              
  Lines        4740     4737       -3     
==========================================
  Hits         3151     3151              
+ Misses       1589     1586       -3
Impacted Files Coverage Δ
src/plugins/image_display/ImageDisplay.cc 31.70% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb7244...a7004dc. Read the comment docs.

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jul 26, 2022
@chapulina chapulina merged commit b53e233 into main Jul 26, 2022
@chapulina chapulina deleted the luca/remove_deprecated_api branch July 26, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees

@luca-della-vedova luca-della-vedova

Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luca-della-vedova @chapulina @mjcarroll